Closed Bug 1162844 Opened 9 years ago Closed 9 years ago

Add meta name="viewmode" to have configurable VR experiences

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

(Whiteboard: [horizon])

User Story

This is a new meta tag which controls the behavior of your site, based on the environment. In the future we can extend the values of this tag to support many options useful for VR and 3D browsers. Initially we will be using this to support a projection key, like:

<meta name="viewmode" content="projection=stereo">
<meta name="viewmode" content="projection=mono">


In the future we will spec this out a bit more and also include things like HMD and orientation  information.

Attachments

(1 file, 5 obsolete files)

[patch] Larch - Add meta name=viewmode to have configurable VR experiences
8.27 KB, patch
kgrandon
: review+
Details | Diff | Splinter Review 
This will be used by horizon.
So we stopped doing moz-prefixed things a while back, but maybe it's okay in this instance given the very experimental nature of this.  Can you write up a quick blurb about how you see it used, and what params it has?
User Story: (updated)
Attachment #8603162 - Attachment is obsolete: true
Summary: Add meta name="moz-environment" to have configurable VR experiences → Add meta name="viewmode" to have configurable VR experiences
User Story: (updated)
Fabrice - can you take a look at this? We are looking to get this into larch initially, but eventually m-c.

Is there any special process for getting this patch on m-c? We're now surfacing an additional meta tag, but only to mozbrowsers, so just wondering if any kind of special review process is necessary.

Thanks!
Attachment #8606237 - Flags: review?(fabrice)
Comment on attachment 8606237 [details] [diff] [review]
[patch] Larch - Add meta name=viewmode to have configurable VR experiences

Review of attachment 8606237 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits fixed.

::: dom/browser-element/mochitest/browserElement_Viewmode.js
@@ +14,5 @@
> +                 .loadFrameScript("data:," + script,
> +                                  /* allowDelayedLoad = */ false);
> +  }
> +
> +  let iframe1 = document.createElement('iframe');

up to this line you used double quotes. Stay consistent one way or the other.
Attachment #8606237 - Flags: review?(fabrice) → review+
(In reply to Kevin Grandon :kgrandon from comment #5)

> Is there any special process for getting this patch on m-c? We're now
> surfacing an additional meta tag, but only to mozbrowsers, so just wondering
> if any kind of special review process is necessary.

Nothing special is needed as I'm a peer of dom/browser-element.
New patch, with nits addressed. Carrying review.
Attachment #8606237 - Attachment is obsolete: true
Attachment #8608858 - Flags: review+
Comment on attachment 8608858 [details] [diff] [review]
[patch] Larch - Add meta name=viewmode to have configurable VR experiences

Review of attachment 8608858 [details] [diff] [review]:
-----------------------------------------------------------------

Fabrice - I've addressed the nits here, could you help me land this patch on larch? Thank you!
Attachment #8608858 - Flags: checkin?(fabrice)
Fabrice - not sure if you get pinged on the checkin? flags. Could you help us get this in larch if you have time? Thanks!
Flags: needinfo?(fabrice)
I'll land it on m-c instead.
Flags: needinfo?(fabrice)
Attachment #8608858 - Flags: checkin?(fabrice)
Attachment #8612266 - Attachment is obsolete: true
Attachment #8604040 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/4d7640929081
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: